Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated version of simple-html-dom-parser library #174

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

tnorthcutt
Copy link
Contributor

Replaces an old version with one updated for PHP 7.3. This is needed because PHP 7.3 changes how it handles regular expressions; the PCRE extension was upgraded: https://secure.php.net/manual/en/migration73.other-changes.php#migration73.other-changes.pcre

Closes #173

Update https://convertkit.slack.com/archives/C526RG58S/p1548965375600800 when released

Replaces an old version with one updated for PHP 7.3. This is needed b/c
PHP 7.3 changes how it handles regular expressions; the PCRE extension was
upgraded: https://secure.php.net/manual/en/migration73.other-changes.php#migration73.other-changes.pcre

Closes #173
Copy link

@pier-oliviert pier-oliviert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tnorthcutt tnorthcutt merged commit f7f4a66 into release/1.7.0 Feb 4, 2019
@tnorthcutt tnorthcutt deleted the issue/173 branch February 4, 2019 20:18
@tnorthcutt tnorthcutt mentioned this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants