Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Fix Uncaught TypeError #762

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Jan 21, 2025

Summary

Fixes this reported issue where clicking Save Changes on the settings screen results in an uncaughty TypeError when a Kit account has no resources, and no checkboxes are checked.

Screenshot 2025-01-21 at 13 32 47

Testing

  • testSettingsScreenWhenNoResources: Updated test to save all settings when the Kit account has no resources and no checkboxes are checked on the settings screen.

Checklist

@n7studios n7studios added the bug label Jan 21, 2025
@n7studios n7studios self-assigned this Jan 21, 2025
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team January 22, 2025 02:09
@n7studios n7studios marked this pull request as ready for review January 22, 2025 02:11
@n7studios n7studios merged commit 2406dbf into main Jan 23, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants