Add foreign key constraints for all projectids #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
changed the title
williamjallen
force-pushed
the
project-foreign-keys
branch
2 times, most recently
from
11b57de to
6fc310a
Compare
williamjallen
force-pushed
the
project-foreign-keys
branch
from
84656a0 to
644c4c0
Compare
williamjallen
force-pushed
the
project-foreign-keys
branch
from
644c4c0 to
71a510f
Compare
josephsnyder
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our database schema is currently a mess. With no foreign keys defined, it is easy to accidentally forget to update a relationship field properly when an entity is created or deleted. Virtually all modern relational databases support foreign key constraints, and there is no reason for us to not add them.
In a first step towards #1442, this PR adds foreign key constraints to all of the table columns which reference a project's ID. This should be a relatively low risk operation for production systems, but it creates a bit of a headache when writing tests, because creating any model which references a project necessarily requires a project model to be created as well.