Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foreign key constraints for all userids #1656

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Add foreign key constraints for all userids #1656

merged 1 commit into from
Aug 18, 2023

Conversation

williamjallen
Copy link
Collaborator

This PR makes progress towards #1442 by adding foreign key constraints to every column which references user IDs.

josephsnyder
josephsnyder approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration looks good and no issues with the test file that changed. Another solid update!

@josephsnyder josephsnyder added this pull request to the merge queue Aug 18, 2023
Merged via the queue into Kitware:master with commit 9f71c66 Aug 18, 2023
@williamjallen williamjallen deleted the user-foreign-keys branch August 18, 2023 14:28
@zackgalbreath zackgalbreath mentioned this pull request Mar 20, 2024
Open
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsnyder josephsnyder josephsnyder approved these changes

Assignees
No one assigned
Labels
release notes: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamjallen @josephsnyder