Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foreign-key constraints to label tables #2452

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add foreign-key constraints to label tables #2452

merged 2 commits into from
Sep 24, 2024

Conversation

williamjallen
Copy link
Collaborator

In support of #2093, this PR adds foreign-key constraints to each of the label pivot tables, as well as a multitude of missing indexes.

@williamjallen williamjallen added this to the v3.6 milestone Sep 20, 2024
josephsnyder
josephsnyder approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with MySQL and docker-compose. It was a no-op but runs and seems like it would be appropriate

@josephsnyder josephsnyder added this pull request to the merge queue Sep 24, 2024
Merged via the queue into Kitware:master with commit 517fb3f Sep 24, 2024
6 checks passed
@williamjallen williamjallen deleted the label-constraints branch September 24, 2024 14:55
zackgalbreath added a commit that referenced this pull request Nov 20, 2024
@zackgalbreath
Eliminate unnecessary DELETE statements in removeBuilds()
2314dd5 
Remove DELETE statements for table that are now handled by cascading
deletions.

* build2uploadfile was fixed in #1657
* label2buildfailure was fixed in #2452
* dynamicanalysisdefect and label2dynamicanalysis were fixed in #2455
@zackgalbreath zackgalbreath mentioned this pull request Nov 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 20, 2024
@zackgalbreath
Eliminate unnecessary DELETE statements in removeBuilds() (#2576)
5d8caad 
Remove DELETE statements for tables that are now handled by cascading
deletions.

* build2uploadfile was fixed in #1657
* label2buildfailure was fixed in #2452
* dynamicanalysisdefect and label2dynamicanalysis were fixed in #2455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsnyder josephsnyder josephsnyder approved these changes

Assignees
No one assigned
Labels
release notes: performance
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@williamjallen @josephsnyder