Make kwcoco a required dependency #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHax
approved these changes
Jan 13, 2025
| @@ -44,11 +44,7 @@ dependencies = [ | |||
| "umap-learn", | |||
| "nrtk[headless]>=0.12.0,<=0.16.0", | |||
| "trame-annotations>=0.4.0", | |||
| ] | |||
|
|
|||
| [project.optional-dependencies] | |||
There was a problem hiding this comment.
Guessing we have to keep this line. Will probably fix CI errors.
PaulHax
force-pushed
the
require-kwcoco
branch
from
84fbf4e to
0e8e9c4
Compare
PaulHax
force-pushed
the
require-kwcoco
branch
from
0e8e9c4 to
a96a158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#156 implicitly makes kwcoco a required dependency, this PR explicitly makes it a required dependency, and removes the fallback class
JsonDataset