fix(domain): Test against js string undefined and null

Prevent invalid domain lookup fix #12
Kitware · Dec 20, 2022 · 8fc0490 · 8fc0490
1 parent bfaef3d
commit 8fc0490
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/trame_simput/module/core.py b/trame_simput/module/core.py
@@ -136,14 +136,10 @@ def push(self, id=None, type=None, domains=None):
         if type:
             self._server.protocol_call("simput.ui.get", self._ui_manager.id, type)
 
-        try:
-            if domains:  # removing int requirement, may have unknown effects
-                self._server.protocol_call(
-                    "simput.domains.get", self._ui_manager.id, domains
-                )
-        except ValueError:
-            # Invalid domain so just skip it...
-            pass
+        if domains and domains not in ["undefined", "null"]:
+            self._server.protocol_call(
+                "simput.domains.get", self._ui_manager.id, domains
+            )
 
     def emit(self, topic, **kwargs):
         logger.info("emit: %s", topic)