New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to read MIE4NITF files #59

Open

m-chaturvedi wants to merge 1 commit into Kitware:master from m-chaturvedi:add_mie4nitf_support

m-chaturvedi commented Nov 14, 2019

To read an MIE4NITF file, we do the following:

In the project file, say test_project.prj, we specify the absolute path to an image list file.
In the image list file, which is assumed to be in the same directory as the frames, we indicate MIE4NITF file using the prefix MIE4NITF:.

For example:

$ cat test_project.prj  
DataSetSpecifier=/home/chaturvedi/images/all_images.txt

-----

$ cat /home/chaturvedi/images/all_images.txt
frame__071.ntf
frame__072.ntf
frame__073.ntf
frame__074.ntf
frame__075.ntf
MIE4NITF:wpr-j2k.r0t0q0c1i1.NTF

-----

$ ls --format=single-column /home/chaturvedi/images/
all_images.txt
frame__001.ntf
frame__002.ntf
frame__071.ntf
frame__072.ntf
frame__073.ntf
frame__074.ntf
frame__075.ntf
wpr-j2k.r0t0q0c1i1.NTF

Note that /home/chaturvedi/images/ may contain more files than what are used.


          Add ability to read MIE4NITF files

171ee2b

mwoehlke-kitware reviewed

View reviewed changes

Member

mwoehlke-kitware left a comment

So far I have only done a fairly superficial review... the style inconsistencies are rather distracting from the actual code. When adding code to any project, please try to follow the prevailing style of the surrounding code.

Applications/VpView/vpFileDataSource.cxx

@@ @@ -128,6 +134,57 @@ void vpFileDataSource::setMonitoringEnabled(bool enable) @@
                 }
               }
+              bool add_mie4nitf_subdatasets (const QString &path, QStringList &list) {

Member

mwoehlke-kitware Nov 21, 2019

Uh... your code style is rather all over the place. Please try to conform to the existing style. (n.b. T& x, not T &x, and Allman braces. Fortunately this is not one of the files still using historic VTK-style braces. Your indenting is also inconsistent.)

Applications/VpView/vpFileDataSource.cxx

+                  if (!dataset)
+                  {
+                    qWarning().nospace()<< "GDAL could not load file." <<

Member

mwoehlke-kitware Nov 21, 2019

Why is nospace() needed here? Also, please put << at the start of the next line, not the end of a line, and align with the prior <<.

Applications/VpView/vpFileDataSource.cxx

+                  if (!dataset)
+                  {
+                    qWarning().nospace()<< "GDAL could not load file." <<
+                      path.toStdString().c_str();

Member

mwoehlke-kitware Nov 21, 2019

Besides that this is the locale-incorrect way to convert to std::string (that would be stdString) or char* (that would be qPrintable), why are you doing this at all? Just pass the QString...

Applications/VpView/vpFileDataSource.cxx


		const QRegExp rgx = QRegExp("SUBDATASET_\\d+_NAME");

		if(key.contains(rgx))

Member

mwoehlke-kitware Nov 21, 2019

Missing braces.

Applications/VpView/vpFileDataSource.cxx

    
            @@ -154,21 +211,54 @@ void vpFileDataSource::update()
          
                  {

                    while (!file.atEnd())

                    {

                      const auto line = file.readLine();

                      QString line = file.readLine().trimmed();

Member

mwoehlke-kitware Nov 21, 2019

Please don't decrease use of AAA.

Applications/VpView/vpFileDataSource.cxx

+                      // use glob to get more than one frames, we use the prefix `MIE4NITF:`
+                      // to indicate that this file contains more than one frame in NITF
+                      // format.
+                      const QString mie4nitf_prefix = "MIE4NITF:";

Member

mwoehlke-kitware Nov 21, 2019

Please use QStringLiteral.

Applications/VpView/vpFileDataSource.cxx

+                      // For ex., in MIE4NITF, frame # 3 inside `/A.ntf` (0-indexed) is
+                      // stored in:
+                      // `NITF_IM:2:/A.ntf`.
+                      QString path_to_check;

Member

mwoehlke-kitware Nov 21, 2019

Please use camelCase for variable names.

Libraries/VtkVgIO/vtkGDALReader.cxx

@@ @@ -138,6 +138,7 @@ void vtkGDALReader::vtkGDALReaderInternal::ReadMetaData( @@
                 this->ReleaseData();
                 this->GDALData = (GDALDataset*) GDALOpen(fileName.c_str(), GA_ReadOnly);
+                std::cout << "Using GDAL reader to open file: " << fileName << std::endl;

Member

mwoehlke-kitware Nov 21, 2019

I wonder how useful this is?

Author

m-chaturvedi commented Dec 5, 2019

@mwoehlke-kitware, we have transferred the files to the following gitlab, I have addressed the comments there:
https://gitlab.kitware.com/LVMI/vivia/merge_requests/1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet