Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ai): (FTI-6403) Fixed error with Azure path override formatting #14051

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix(ai): (FTI-6403) Fixed error with Azure path override formatting #14051

merged 2 commits into from
Jan 17, 2025

Conversation

tysoekong
Copy link
Contributor

Summary

There was a bug found, where the Azure provider stopped parsing 'custom upstream path' overrides since Kong 3.9.0.

Every request would 404 due to incorrect parsing.

I've added a parser / config options test to prevent this from happening again!

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md

Issue reference

FTI-6403
AG-191

@tysoekong tysoekong requested review from fffonion and oowl December 24, 2024 20:51
@tysoekong tysoekong force-pushed the fix/ai_preserve_route_type branch from 9c0c579 to bedbcc7 Compare December 24, 2024 20:52
oowl
oowl reviewed Dec 30, 2024
View reviewed changes
kong/llm/drivers/azure.lua Outdated Show resolved Hide resolved
kong/llm/drivers/azure.lua Outdated Show resolved Hide resolved
kong/llm/drivers/azure.lua Outdated Show resolved Hide resolved
fffonion
fffonion reviewed Jan 8, 2025
View reviewed changes
kong/llm/drivers/shared.lua Outdated Show resolved Hide resolved
kong/llm/drivers/azure.lua Outdated Show resolved Hide resolved
@tysoekong
Copy link
Contributor Author

@fffonion @oowl There's nothing I can actually change here, based on the comments - it's all necessary to get this to run as previously experienced by the customer.

@oowl oowl force-pushed the fix/ai_preserve_route_type branch 3 times, most recently from c9afd58 to 3391c06 Compare January 16, 2025 10:09
RobSerafini
RobSerafini approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@RobSerafini RobSerafini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport Approved

@oowl oowl force-pushed the fix/ai_preserve_route_type branch from fcad36a to 008e80e Compare January 17, 2025 07:31
@oowl oowl force-pushed the fix/ai_preserve_route_type branch from 008e80e to 83f2f3f Compare January 17, 2025 08:13
@fffonion fffonion merged commit 443c075 into master Jan 17, 2025
26 checks passed
@fffonion fffonion deleted the fix/ai_preserve_route_type branch January 17, 2025 09:33
@team-gateway-bot team-gateway-bot mentioned this pull request Jan 17, 2025
Open
2 tasks
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.9.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobSerafini RobSerafini RobSerafini approved these changes

@oowl oowl oowl approved these changes

@fffonion fffonion fffonion approved these changes

Assignees

@tysoekong tysoekong

Labels
backport release/3.9.x cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/ai-proxy plugins/ai-request-transformer plugins/ai-response-transformer size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tysoekong @team-gateway-bot @fffonion @oowl @RobSerafini