refactor(clustering/sync): improve readability and debugability #14170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
StarlightIbuki
force-pushed
the
refactor/rpc-sync-ce
branch
from
7bd1142 to
00bb83b
Compare
StarlightIbuki
removed
the
cherry-pick kong-ee
StarlightIbuki
force-pushed
the
refactor/rpc-sync-ce
branch
from
00bb83b to
1a34b5a
Compare
github-actions
bot
added
the
cherry-pick kong-ee
chronolaw
changed the title
chronolaw
reviewed
Jan 15, 2025
StarlightIbuki
force-pushed
the
refactor/rpc-sync-ce
branch
3 times, most recently
from
537d6f2 to
b18175b
Compare
StarlightIbuki
commented
Jan 15, 2025
StarlightIbuki
force-pushed
the
refactor/rpc-sync-ce
branch
4 times, most recently
from
ee07453 to
43975e3
Compare
chobits
approved these changes
Jan 16, 2025
chobits
reviewed
Jan 16, 2025
StarlightIbuki
force-pushed
the
refactor/rpc-sync-ce
branch
9 times, most recently
from
d9940f1 to
2ecd057
Compare
StarlightIbuki
force-pushed
the
refactor/rpc-sync-ce
branch
2 times, most recently
from
354b255 to
2918b81
Compare
1. abstract functions and reshape the code, including error handling 2. extra call to notify CP the state of sync; 3. more debuging logs; 4. sync once retry will not count timeout as retry, allowing DP to sync deltas right after a full sync KAG-6177
StarlightIbuki
force-pushed
the
refactor/rpc-sync-ce
branch
from
2918b81 to
8ae2931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-6177