tests(clustering): enable rpc sync on test #14171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
lhanjian
commented
Jan 15, 2025
| describe("in hybrid mode" .. " rpc_sync=" .. rpc_sync, function() | ||
| local route | ||
| local plugin_name = "correlation-id" | ||
| local bp, db = helpers.get_db_utils(strategy, { "plugins", "workspaces", }) |
lhanjian
changed the title
lhanjian
force-pushed
the
test/open_rpc_sync_on
branch
from
9808629 to
b28f375
Compare
chronolaw
reviewed
Jan 15, 2025
| lazy_setup(function() | ||
| -- copy from outer lazy_setup, to avoid database reused. |
There was a problem hiding this comment.
Need more words to explain why and how it works.
|
|
chronolaw
reviewed
Jan 15, 2025
| lazy_setup(function() | ||
| -- if the database is not cleared, the residual RPC connection information between different tests will cause the test to fail. |
There was a problem hiding this comment.
long line, should break it into two lines.
There was a problem hiding this comment.
Do we have any other simple way to clear the db?
There was a problem hiding this comment.
Clearing data and then recreating a new database is more dirty.
Co-authored-by: Chrono <[email protected]>
Co-authored-by: Chrono <[email protected]>
lhanjian
force-pushed
the
test/open_rpc_sync_on
branch
from
d55beef to
b9bde94
Compare
lhanjian
force-pushed
the
test/open_rpc_sync_on
branch
from
76f5bac to
579a57c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5561