Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(clustering): clean assertions in batch tests #14177

Merged
merged 3 commits into from
Jan 17, 2025
Merged

tests(clustering): clean assertions in batch tests #14177

merged 3 commits into from
Jan 17, 2025

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jan 16, 2025 •
edited
Loading

Summary

KAG-5934

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 16, 2025
@chronolaw chronolaw marked this pull request as ready for review January 16, 2025 07:10
@ADD-SP ADD-SP merged commit 902e16a into master Jan 17, 2025
25 checks passed
@ADD-SP ADD-SP deleted the tests/remove_pwait_until branch January 17, 2025 02:08
@ADD-SP ADD-SP added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jan 17, 2025
@ADD-SP
Copy link
Contributor

ADD-SP commented Jan 17, 2025

Please also cherry-pick to EE.

@ADD-SP ADD-SP removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @ADD-SP @chobits