Skip to content

Commit

Permalink
test fix, todo
Browse files Browse the repository at this point in the history
  • Loading branch information
Kyagara committed May 15, 2024
1 parent d7f556f commit 3b7e412
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ func main() {
- Maybe the context usage throughout the project could be improved
- Maybe add and move logging to the Cache and RateLimit interfaces, instead of passing them around
- Maybe endpoint methods int32/int64 should be changed to just int
- Maybe models int32/int64 should be changed to just int
- Add checks for duration of tests that include any WaitN/any blocking
- Add more integration tests
- RateLimit
Expand Down
4 changes: 0 additions & 4 deletions internal/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,6 @@ func TestRequests(t *testing.T) {
bodyBytes, err := io.ReadAll(equinoxReq.Request.Body)
require.NoError(t, err)
require.Equal(t, expectedBody, bodyBytes)
require.Equal(t, "application/json", equinoxReq.Request.Header.Get("Content-Type"))
require.Equal(t, "application/json", equinoxReq.Request.Header.Get("Accept"))
require.Equal(t, config.Key, equinoxReq.Request.Header.Get("X-Riot-Token"))
})

Expand All @@ -147,8 +145,6 @@ func TestRequests(t *testing.T) {

require.Equal(t, expectedURL, equinoxReq.Request.URL.String())
require.Nil(t, equinoxReq.Request.Body)
require.Equal(t, "application/json", equinoxReq.Request.Header.Get("Content-Type"))
require.Equal(t, "application/json", equinoxReq.Request.Header.Get("Accept"))
require.Equal(t, config.Key, equinoxReq.Request.Header.Get("X-Riot-Token"))
})

Expand Down

0 comments on commit 3b7e412

Please sign in to comment.