Fix animation cache not working when image is behind a symlink #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that for large gifs swww takes a long time to send them to the daemon. I tried seeing if I could parallelize the process somehow but instead found that the cache just wasn't working. Fixing the cache gives a lot more performance than parallelizing the compression of the frames.
Parallelizing the compression can however be done. I did a little bit of investigating and realized that, while
pack_bytes
has to be done sequentially. Compressinglz4
itself doesn't need to be. And after measuring the time each of those two operations take, it might be worth it.Rough measurments in a busy machine