Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implement 3D grid generation #256

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Dec 13, 2024

Description

Scope: core

Type of change: feat

Content description: TODO

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 223 lines in your changes missing coverage. Please review.

Project coverage is 83.27%. Comparing base (2701d38) to head (5be6c92).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/builder/grid.rs 0.00% 223 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   85.31%   83.27%   -2.04%     
==========================================
  Files          62       62              
  Lines        9111     9334     +223     
==========================================
  Hits         7773     7773              
- Misses       1338     1561     +223     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99
Copy link
Collaborator Author

imrn99 commented Jan 2, 2025

TODO:

  • add vertex insertion
  • add another drawing of the expected IDs?
  • wire the routines to the builder
  • tests

@imrn99 imrn99 changed the title feat(core): add internal routine for 3D grid generation feat(core): implement 3D grid generation Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants