Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(kernels): convert split_edge routines to use transactions #268

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Jan 21, 2025

Description

Scope: kernels

Type of change: refactor

Content description:

  • rename split_edge_no_alloc & splitn_edge_no_alloc to split_edge_transac & splitn_edge_transac
  • update API of both methods to accept transactions
  • update SplitEdgeError to have a failed transaction variant
  • update common internal routine to use a transaction

Additional information

  • Breaking change

Necessary follow-up

merge this back into #269 and finish writing the new benchmark.

@imrn99 imrn99 marked this pull request as ready for review January 21, 2025 14:52
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.41558% with 36 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (6e38028) to head (b36ea20).

Files with missing lines Patch % Lines
honeycomb-kernels/src/splits/tests.rs 73.49% 22 Missing ⚠️
honeycomb-kernels/src/splits/edge_multiple.rs 95.38% 3 Missing ⚠️
honeycomb-kernels/src/splits/edge_single.rs 94.82% 3 Missing ⚠️
honeycomb-kernels/src/splits/mod.rs 0.00% 3 Missing ⚠️
...-kernels/src/grisubal/routines/insert_intersecs.rs 81.81% 2 Missing ⚠️
...-kernels/src/grisubal/routines/insert_new_edges.rs 80.00% 2 Missing ⚠️
honeycomb-kernels/src/grisubal/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   85.14%   85.09%   -0.05%     
==========================================
  Files          62       63       +1     
  Lines        8924     9024     +100     
==========================================
+ Hits         7598     7679      +81     
- Misses       1326     1345      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imrn99 imrn99 merged commit 80ee899 into master Jan 22, 2025
13 checks passed
@imrn99 imrn99 deleted the make-split-edge-transactional branch January 22, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants