Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add custom (de)serialization format & support #276

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Feb 6, 2025

Description

Scope: core

Type of change: feat

Content description:

  • define a custom serialization format for combinatorial maps
    • the spec is detailed in a new UG page
  • add corresponding implementations
    • a serialize methods to CMap2 and CMap3
    • a cmap_file method to CMapBuilder

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0.63291% with 314 lines in your changes missing coverage. Please review.

Project coverage is 82.47%. Comparing base (2701d38) to head (57ffe9f).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/builder/io.rs 0.00% 139 Missing ⚠️
honeycomb-core/src/cmap/dim3/serialize.rs 0.00% 85 Missing ⚠️
honeycomb-core/src/cmap/dim2/serialize.rs 0.00% 77 Missing ⚠️
honeycomb-core/src/cmap/builder/structure.rs 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   85.31%   82.47%   -2.84%     
==========================================
  Files          62       63       +1     
  Lines        9111     9427     +316     
==========================================
+ Hits         7773     7775       +2     
- Misses       1338     1652     +314     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99
Copy link
Collaborator Author

imrn99 commented Feb 7, 2025

TODO:

  • finish processing the last todo!s
  • add serialization test
  • add deserialization test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants