Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ramble version #523

Merged
merged 25 commits into from
Jan 30, 2025
Merged

Update ramble version #523

merged 25 commits into from
Jan 30, 2025

Conversation

dyokelson
Copy link
Collaborator

@dyokelson dyokelson commented Jan 6, 2025

Description

Update pinned version of Ramble to one from Jan 8, 2025

Dependencies: Ramble removes support for "SpackModifier" and the replacement is "BasicModifier"

Fixes issue(s): This will be required to get the new Ramble for upcoming caliper metadata functionality.

Type of Change

  • { } Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { x } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@github-actions github-actions bot added ci CI, unit tests, GitHub actions application labels Jan 7, 2025
@dyokelson dyokelson requested review from rfhaque and pearce8 January 8, 2025 22:29
@dyokelson dyokelson marked this pull request as ready for review January 8, 2025 22:30
@dyokelson dyokelson added the ready for review Ready for review label Jan 8, 2025
Copy link
Collaborator

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is gitlab CI failing?

@dyokelson
Copy link
Collaborator Author

@slabasan can you help me look at the CI logs tomorrow? I'm having trouble navigating gitlab to find more error details. All I can see is we're getting an exit code 1 during spack install:

==> *******************************************
==> ********** Running spack Command **********
==> **     command: /g/g0/benchpark/.jacamar-ci/builds/LxhAF2MC/001/gitlab/brink2/benchpark/workspace/spack/bin/spack install
==> **     with args: ['--add', '--keep-stage']
==> *******************************************
==> 
logout
Jan 08 14:52:21.942050 PST broker.err[0]: rc2.0: /g/g0/benchpark/.jacamar-ci/scripts/LxhAF2MC/001/brink2/benchpark/2335412/build_script.bash Exited (rc=1) 507.3s
flux-job: task(s) exited with exit code 1
logout
[0;33mError encountered during job: exit status 1[0;m
[0;33mError encountered during job: Error executing run_exec: exit status 1

@dyokelson dyokelson removed the ready for review Ready for review label Jan 11, 2025
@slabasan
Copy link
Collaborator

@dyokelson I'm seeing salmon-related commits in this PR, is this expected?

@dyokelson
Copy link
Collaborator Author

dyokelson commented Jan 13, 2025

@dyokelson I'm seeing salmon-related commits in this PR, is this expected?

@slabasan Yea, the ramble update changed the inheritance and removed support for "SpackApplication" so those are the only changes. It shouldn't break in old salmon/genesis until we update ramble so should be okay no matter which order these PRs get merged.

@dyokelson dyokelson self-assigned this Jan 27, 2025
@dyokelson dyokelson added this to the Urgent v0.1.1 milestone Jan 27, 2025
@dyokelson dyokelson requested a review from pearce8 January 30, 2025 19:51
@dyokelson dyokelson added the ready for review Ready for review label Jan 30, 2025
@pearce8 pearce8 merged commit 910b6d8 into develop Jan 30, 2025
13 checks passed
@pearce8 pearce8 deleted the update-ramble branch January 30, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application ci CI, unit tests, GitHub actions ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants