-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding progress tracking for files and directories #10
Adding progress tracking for files and directories #10
Conversation
Adding Progress
Thanks for your pull request! Just a question, what is your idea behind "currentProgress" and "totalItems"? From what I can see, they are both values representing current progress, but the first is number of files and the other one is number of files + number of directories? |
users can get a more detailed view of the progress of the operation. For instance, if "currentProgress" is 50 and "totalItems" is 100 |
Okay. To make things more clear and easy to understand, I think I'll rename them "totalFiles" and "totalItems" instead. Otherwise it might be mistaken as referring to current number of items and total number of items about to be added to the file system. |
Or maybe "currentFilesCount" and "currentItemsCount". That should make it clear. |
yes that would work |
readability
@LTRData does this one help now hoepfully |
I changed it a bit a introduced a more generic event for progress updates in base interface Merged into main branch now. |
should i close this now since you didn't merge this |
Yes, we can close this. |
ok alo increasing the speed as well I have done this but I'm sure there is a better way |
This pull request introduces progress tracking for both files and directories during operations.
Added UpdateProgress(_files.Count, _files.Count + _dirs.Count); to update progress during operations.
Ensured accurate progress calculation for both files and directories.
The addition of progress tracking enhances user experience by providing real-time feedback during operations. Users will now have better visibility into the progress of file and directory operations, improving overall usability and user satisfaction.