Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CubeHub.dk #1567

Merged
merged 13 commits into from
Jan 7, 2025
Merged

Updated CubeHub.dk #1567

merged 13 commits into from
Jan 7, 2025

Conversation

Koldskal
Copy link
Contributor

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link

Just as an information regarding your wildcards:

  • Wildcard %.cubehub.dk seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

Just as an information:

  • The website https://cubehub.dk could not be reached. Please recheck whether is available.

Copy link

Just as an information regarding your wildcards:

  • Wildcard %.cubehub.dk seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@Koldskal Koldskal requested a review from maaaathis January 6, 2025 19:05
@DoJapHD
Copy link
Collaborator

DoJapHD commented Jan 6, 2025

As the wildcard is invalid, remove it and after that I can approve the PR

Copy link

github-actions bot commented Jan 6, 2025

Just as an information:

  • The website https://cubehub.dk could not be reached. Please recheck whether is available.

@Koldskal
Copy link
Contributor Author

Koldskal commented Jan 6, 2025

As the wildcard is invalid, remove it and after that I can approve the PR

Fixed

@@ -2,28 +2,32 @@
"server_name": "cubehub",
"nice_name": "CubeHub",
"direct_ip": "CubeHub.dk",
"server_wildcards": [
"%.cubehub.dk"
],
"supported_languages": [
"dk"
],
"social": {
"web": "https://cubehub.dk",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website seems to just be a template

Copy link
Contributor Author

@Koldskal Koldskal Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website is set to Maintance.. And the wildcard has been removed in the latest commit.

@DoJapHD DoJapHD merged commit 8e9f02d into LabyMod:master Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants