LibWeb/CSS: Consider unresolved calc() when serializing in Normal mode #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasChollet
changed the title
LucasChollet
force-pushed
the
serialize_none
branch
from
14f45ac to
c59bcca
Compare
|
Oops, I forgot to rebase the test. |
Unfortunately, there is no explicit and step-by-step spec to perform the serialization of `color()` declared values, so while being spec-informed, this is quite ad-hoc. Fixes 81 subtests in: - css/css-color/parsing/color-valid-color-function.html
LucasChollet
force-pushed
the
serialize_none
branch
from
c59bcca to
f6cf1c4
Compare
AtkinsSJ
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, there is no explicit and step-by-step spec to perform the serialization of
color()declared values, so while being spec-informed, this is quite ad-hoc.Fixes 81 subtests in: