feat(oft-solana): introduce addComputeUnitInstructions

[ryandgoulding]

No description provided.

[ryandgoulding]

not ready for review, just letting it go through CI pipeline as it is faster than doing so locally

[DanL0]

@ryandgoulding can you resolve conflict?

[ryandgoulding]

@DanL0 done, can you take a look?

[nazreen]

I tested locally and here are my results, using the time utility in the terminal to measure

task ran: createOFT

without calling addPerformanceInstructions

pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.02s user 0.34s system 4% cpu 53.281 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  1.99s user 0.35s system 4% cpu 52.599 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.04s user 0.37s system 4% cpu 53.974 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  1.83s user 0.32s system 5% cpu 40.226 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true   1.95s user 0.34s system 4% cpu 52.211 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true   2.02s user 0.34s system 4% cpu 53.015 total

with calling addPerformanceInstructions

pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.06s user 0.33s system 5% cpu 42.535 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.04s user 0.37s system 4% cpu 53.974 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.17s user 0.37s system 3% cpu 1:04.41 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.27s user 0.36s system 4% cpu 1:05.64 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.05s user 0.35s system 5% cpu 43.787 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  1.99s user 0.34s system 5% cpu 39.079 total

So overall it does improve transactions processing times

@ryandgoulding we can merge it, just need to fix the getFee interface change and rename the function

If you want me to help, I don't mind

[ryandgoulding]

I tested locally and here are my results, using the time utility in the terminal to measure

task ran: createOFT

without calling addPerformanceInstructions

pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.02s user 0.34s system 4% cpu 53.281 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  1.99s user 0.35s system 4% cpu 52.599 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.04s user 0.37s system 4% cpu 53.974 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  1.83s user 0.32s system 5% cpu 40.226 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true   1.95s user 0.34s system 4% cpu 52.211 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true   2.02s user 0.34s system 4% cpu 53.015 total

with calling addPerformanceInstructions

pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.06s user 0.33s system 5% cpu 42.535 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.04s user 0.37s system 4% cpu 53.974 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.17s user 0.37s system 3% cpu 1:04.41 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.27s user 0.36s system 4% cpu 1:05.64 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  2.05s user 0.35s system 5% cpu 43.787 total
pnpm hardhat lz:oft:solana:create --eid 40168 --program-id $PROGRAM_ID  true  1.99s user 0.34s system 5% cpu 39.079 total

So overall it does improve transactions processing times

@ryandgoulding we can merge it, just need to fix the getFee interface change and rename the function

If you want me to help, I don't mind

Sure, please feel free to take over the branch!

[nazreen]

@ryandgoulding changes made

Summary:

• renamed addPerformanceInstructions to addComputeUnitInstructions
• removed computeUnitLimitScaleFactor as a param, but kept it as a local variable inside addComputeUnitInstructions
• updated the getPrioritizationFee interface to make programId optional

I've Approved, but we should only merge after you also review

[nazreen]

Applied 'do not merge' as running into error when running the create task

Ran pnpm hardhat lz:oft:solana:create --eid 30168 --program-id <PROGRAM_ID> --compute-unit-price-scale-factor 2 --only-oft-store true

Got error

Message: Transaction simulation failed: Attempt to debit an account but found no record of a prior credit..

EDIT: was using mainnet eid accidentally

[nazreen]

@ryandgoulding I've tested by running

pnpm hardhat lz:oft:solana:create --eid 40168 --program-id <PROGRAM_ID> --compute-unit-price-scale-factor 2 --only-oft-store true

and it works fine, on devnet

[nazreen]

was surprised that checks here were failing so I created a PR based off of latest main that only has an empty commit

it's failing too - #1138

[nazreen]

if after latest run of CI (after merging in main that has the fix), checks pass, Do Not Merge label should be removed.

reported error has been fixed by 8fbdfb1

reviewer is on PTO but we are receiving reports from partners running into difficulty landing transactions, which can be resolved by this PR getting merged