Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Docker cache #940

Merged
merged 1 commit into from
Oct 25, 2024
Merged

🧹 Docker cache #940

merged 1 commit into from
Oct 25, 2024

Conversation

janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Oct 22, 2024 •
edited
Loading

In this PR

  • Create cache artifacts in GHCR instead of the GHA cache. This means that the layers of all, including the intermediate, images will be uploaded to GHCR
  • The cache will try to use the layers built for its branch will fallback to the main branch cache

@janjakubnanista janjakubnanista marked this pull request as draft October 22, 2024 23:42
@janjakubnanista janjakubnanista force-pushed the docker-cache branch 2 times, most recently from 7e21754 to c58f9e1 Compare October 23, 2024 17:45
@janjakubnanista janjakubnanista changed the title 🧹 Better scoping for docker cache 🧹 Docker cache Oct 25, 2024
@janjakubnanista janjakubnanista marked this pull request as ready for review October 25, 2024 18:57
ravinagill15
ravinagill15 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@ravinagill15 ravinagill15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ravinagill15 ravinagill15 merged commit e36c2bb into main Oct 25, 2024
16 checks passed
@ravinagill15 ravinagill15 deleted the docker-cache branch October 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinagill15 ravinagill15 ravinagill15 approved these changes

@ryandgoulding ryandgoulding Awaiting requested review from ryandgoulding

@shankars99 shankars99 Awaiting requested review from shankars99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janjakubnanista @ravinagill15