Merge branch 'slashing-magnitudes-fixes' into delegate-shares-fix

Layr-Labs · Feb 5, 2025 · c5d71cf · c5d71cf
2 parents bfa0c7f + 38f5faa
commit c5d71cf
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 0 deletions.
diff --git a/src/contracts/core/DelegationManager.sol b/src/contracts/core/DelegationManager.sol
@@ -307,6 +307,9 @@ contract DelegationManager is
             sharesToDecrease: operatorSharesSlashed
         });
 
+        // Emit event for operator shares being slashed
+        emit OperatorSharesSlashed(operator, strategy, totalDepositSharesToBurn);
+
         IShareManager shareManager = _getShareManager(strategy);
         // NOTE: for beaconChainETHStrategy, increased burnable shares currently have no mechanism for burning
         shareManager.increaseBurnableShares(strategy, totalDepositSharesToBurn);

diff --git a/src/contracts/interfaces/IDelegationManager.sol b/src/contracts/interfaces/IDelegationManager.sol
@@ -170,6 +170,9 @@ interface IDelegationManagerEvents is IDelegationManagerTypes {
 
     /// @notice Emitted when a queued withdrawal is completed
     event SlashingWithdrawalCompleted(bytes32 withdrawalRoot);
+
+    /// @notice Emitted whenever an operator's shares are slashed for a given strategy
+    event OperatorSharesSlashed(address indexed operator, IStrategy strategy, uint256 totalSlashedShares);
 }
 
 /**

diff --git a/src/test/unit/DelegationUnit.t.sol b/src/test/unit/DelegationUnit.t.sol
@@ -6622,6 +6622,11 @@ contract DelegationManagerUnitTests_slashingShares is DelegationManagerUnitTests
                 sharesToBurn: sharesToBurn
             })
         );
+
+        // Assert OperatorSharesSlashed event was emitted with correct params
+        cheats.expectEmit(true, true, true, true, address(delegationManager));
+        emit OperatorSharesSlashed(operator, strategyMock, sharesToBurn);
+
         cheats.prank(address(allocationManagerMock));
         delegationManager.slashOperatorShares({
             operator: operator,
@@ -6708,6 +6713,11 @@ contract DelegationManagerUnitTests_slashingShares is DelegationManagerUnitTests
                 sharesToBurn: sharesToBurn
             })
         );
+
+        // Assert OperatorSharesSlashed event was emitted with correct params
+        cheats.expectEmit(true, true, true, true, address(delegationManager));
+        emit OperatorSharesSlashed(operator, strategyMock, sharesToBurn);
+
         cheats.prank(address(allocationManagerMock));
         delegationManager.slashOperatorShares({
             operator: operator,
@@ -6790,6 +6800,11 @@ contract DelegationManagerUnitTests_slashingShares is DelegationManagerUnitTests
                 sharesToBurn: sharesToBurn
             })
         );
+
+        // Assert OperatorSharesSlashed event was emitted with correct params
+        cheats.expectEmit(true, true, true, true, address(delegationManager));
+        emit OperatorSharesSlashed(operator, strategyMock, sharesToBurn);
+
         cheats.prank(address(allocationManagerMock));
         delegationManager.slashOperatorShares({
             operator: operator,
@@ -6887,6 +6902,11 @@ contract DelegationManagerUnitTests_slashingShares is DelegationManagerUnitTests
                 sharesToBurn: sharesToBurn
             })
         );
+
+        // Assert OperatorSharesSlashed event was emitted with correct params
+        cheats.expectEmit(true, true, true, true, address(delegationManager));
+        emit OperatorSharesSlashed(operator, strategyMock, sharesToBurn);
+
         cheats.prank(address(allocationManagerMock));
         delegationManager.slashOperatorShares({
             operator: operator,
@@ -6971,6 +6991,11 @@ contract DelegationManagerUnitTests_slashingShares is DelegationManagerUnitTests
                     sharesToBurn: sharesToBurn
                 })
             );
+
+            // Assert OperatorSharesSlashed event was emitted with correct params
+            cheats.expectEmit(true, true, true, true, address(delegationManager));
+            emit OperatorSharesSlashed(operator, strategyMock, sharesToBurn);
+
             cheats.prank(address(allocationManagerMock));
             delegationManager.slashOperatorShares({
                 operator: operator,
@@ -7025,6 +7050,11 @@ contract DelegationManagerUnitTests_slashingShares is DelegationManagerUnitTests
                     sharesToBurn: sharesToBurn
                 })
             );
+
+            // Assert OperatorSharesSlashed event was emitted with correct params
+            cheats.expectEmit(true, true, true, true, address(delegationManager));
+            emit OperatorSharesSlashed(operator, strategyMock, sharesToBurn);
+
             cheats.prank(address(allocationManagerMock));
             delegationManager.slashOperatorShares({
                 operator: operator,
@@ -7129,6 +7159,11 @@ contract DelegationManagerUnitTests_slashingShares is DelegationManagerUnitTests
                 sharesToBurn: 0
             })
         );
+
+        // Assert OperatorSharesSlashed event was emitted with correct params
+        cheats.expectEmit(true, true, true, true, address(delegationManager));
+        emit OperatorSharesSlashed(operator, strategyMock, 0);
+
         cheats.prank(address(allocationManagerMock));
         delegationManager.slashOperatorShares({
             operator: operator,
@@ -7205,6 +7240,11 @@ contract DelegationManagerUnitTests_slashingShares is DelegationManagerUnitTests
         _setOperatorMagnitude(operator, beaconChainETHStrategy, newMagnitude);
         cheats.expectEmit(true, true, true, true, address(delegationManager));
         emit OperatorSharesDecreased(operator, address(0), beaconChainETHStrategy, sharesToDecrease);
+
+        // Assert OperatorSharesSlashed event was emitted with correct params
+        cheats.expectEmit(true, true, true, true, address(delegationManager));
+        emit OperatorSharesSlashed(operator, beaconChainETHStrategy, sharesToDecrease);
+
         cheats.prank(address(allocationManagerMock));
         delegationManager.slashOperatorShares({
             operator: operator,
@@ -7254,6 +7294,10 @@ contract DelegationManagerUnitTests_slashingShares is DelegationManagerUnitTests
             newOperatorMagnitude -= slashMagnitude;
             _setOperatorMagnitude(defaultOperator, strategyMock, newOperatorMagnitude);
 
+            // Assert OperatorSharesSlashed event was emitted with correct params
+            cheats.expectEmit(true, true, true, true, address(delegationManager));
+            emit OperatorSharesSlashed(defaultOperator, strategyMock, 44440000449046438731194137360795695);
+
             cheats.prank(address(allocationManagerMock));
             delegationManager.slashOperatorShares(
                 defaultOperator, strategyMock, newOperatorMagnitude + slashMagnitude, newOperatorMagnitude