fix: signature utils #1015

0xClandestine · 2025-01-11T00:29:20Z

Changes:

Dynamic Domain Separator: SignatureUtils.domainSeparator() is now recomputed for each signature verification. This eliminates the need for storing initial values in storage or as immutables, which is important for beacon proxy support.
Version Bump Command: Introduced make bump-version VERSION=2, which automatically updates the version function's return values.
Version Fn + Constructor Param: Adds an immutable oz ShortString that's set in the constructor.

ypatil12

Can we sanity check that the domain separator of the DM/RC/AVSD is based on the proxy and not the implementation

0xClandestine · 2025-01-11T01:01:13Z

Can we sanity check that the domain separator of the DM/RC/AVSD is based on the proxy and not the implementation

Oops, forgot that. Will do.

ypatil12

Comments regarding version number

bin/bump-version.sh

src/contracts/core/AVSDirectory.sol

src/contracts/core/DelegationManager.sol

src/test/unit/RewardsCoordinatorUnit.t.sol

0xClandestine · 2025-01-13T15:27:12Z

Check storage layout ci failing due to SignatureUtils -> SignatureUtilsMixin.

src/contracts/core/StrategyManager.sol

src/contracts/mixins/SignatureUtilsMixin.sol

src/contracts/core/AVSDirectory.sol

Makefile

script/configs/devnet/deploy_from_scratch.anvil.config.json

ypatil12

So far looks good, we should also add SemverMixin to the EigenPodManager and StrategyFactory.

We may want to also add to all Strategies and EigenPods too (can talk in standup about this one).

script/configs/mainnet/mainnet-addresses.config.json

ypatil12 · 2025-01-22T14:46:30Z

script/releases/Env.sol

@@ -53,6 +53,10 @@ library Env {
     * env
     */

+    function version() internal view returns (string memory) {
+        return _envString("version");


Can you coordinate with @jbrower95 to make sure this is a parameter in the Zeus config that the upgrade scripts can access

in progress

To add to this, but maybe overkill, we may want to have zeus config to have semver for each contract. Some of our upgrades will touch just a few contracts so the versions will be different at a point in time

Ahh that's a good point, so rather than a single config param, there's one per contract?

Ya that would make sense to me

Just noting we decided against this...

Ahh that's a good point, so rather than a single config param, there's one per contract?

src/contracts/core/DelegationManager.sol

src/contracts/mixins/SemVerMixin.sol

src/contracts/interfaces/IRewardsCoordinator.sol

src/contracts/interfaces/ISignatureUtilsMixin.sol

8sunyuan · 2025-01-22T16:10:39Z

src/contracts/strategies/EigenStrategy.sol

Yeah not entirely sure if we want to change EigenStrategy here. I figure the Eigen/EigenStrategy changes will take place in its own separate upgrade.

We upgraded the EigenStrategy in the initial upgrade, so we should be good. Eigen can be separate:

eigenlayer-contracts/script/releases/v1.0.0-slashing/1-deployContracts.s.sol

Lines 153 to 159 in 7a6f8a6

deployImpl({

name: type(EigenStrategy).name,

deployedTo: address(new EigenStrategy({

_strategyManager: Env.proxy.strategyManager(),

_pauserRegistry: Env.impl.pauserRegistry()

}))

});

ypatil12

LGTM, approving. Just need to coordinate with @jbrower95 on the Zeus changes

ypatil12 · 2025-01-22T20:14:29Z

Oh, can we also update the storage diff for sanity?

ypatil12 · 2025-01-22T22:15:27Z

LGTM, approving. Just need to coordinate with @jbrower95 on the Zeus changes

Spoke with @jbrower95, we're just going to add a Zeus helper solidity script to tick the version. Will be done in a separate PR

ypatil12

Blocking for now - let's wait to merge until we have all audit fixes in

refactor: review changes refactor: review changes feat: remaining semver feat: remaining semver refactor: review changes refactor: review changes fix: ci refactor: remove make cmd fix: ci fix: ci feat: add `SemVerMixin` (#1034) * feat: add `SemVerMixin` * refactor: add `_majorVersion` helper for `SignatureUtils` * test: passing * test: passing * refactor: rename EIP712_VERSION * refactor: review changes chore: forge fmt refactor: natspec improvements chore: forge fmt fix: eip712 typehash refactor: remove version overrides refactor: remove make bump-version refactor: immutable version refactor: remove unused import chore: `make bump-version VERSION=1` refactor: `SignatureUtils` -> `SignatureUtilsMixin` fix: bump-version.sh chore: `make bump-version VERSION=1.0.3` feat: add `make bump-version` feat: add version fn refactor: cleanup fix: signature utils

0xClandestine mentioned this pull request Jan 11, 2025

refactor: signature utils #1009

Closed

ypatil12 reviewed Jan 11, 2025

View reviewed changes

bin/bump-version.sh Outdated Show resolved Hide resolved

src/contracts/core/AVSDirectory.sol Outdated Show resolved Hide resolved

src/contracts/core/DelegationManager.sol Outdated Show resolved Hide resolved

src/test/unit/RewardsCoordinatorUnit.t.sol Outdated Show resolved Hide resolved

wadealexc force-pushed the slashing-magnitudes-fixes branch from 1427a85 to 403e0a1 Compare January 13, 2025 19:58

0xClandestine force-pushed the fix/signature-utils branch 2 times, most recently from 4189591 to 6d5d06b Compare January 16, 2025 19:23

8sunyuan reviewed Jan 16, 2025

View reviewed changes

src/contracts/core/StrategyManager.sol Outdated Show resolved Hide resolved

8sunyuan reviewed Jan 16, 2025

View reviewed changes

src/contracts/mixins/SignatureUtilsMixin.sol Outdated Show resolved Hide resolved

8sunyuan reviewed Jan 16, 2025

View reviewed changes

src/contracts/core/AVSDirectory.sol Show resolved Hide resolved

0xClandestine mentioned this pull request Jan 17, 2025

feat: add SemVerMixin #1034

Merged

0xClandestine force-pushed the fix/signature-utils branch from 943d7ee to 0aa946b Compare January 21, 2025 21:18

0xClandestine commented Jan 22, 2025

View reviewed changes

Makefile Outdated Show resolved Hide resolved

0xClandestine commented Jan 22, 2025

View reviewed changes

script/configs/devnet/deploy_from_scratch.anvil.config.json Outdated Show resolved Hide resolved

0xClandestine requested review from ypatil12 and 8sunyuan January 22, 2025 14:31

ypatil12 requested changes Jan 22, 2025

View reviewed changes

0xClandestine mentioned this pull request Jan 22, 2025

feat: add remaining semver #1041

Merged

0xClandestine force-pushed the fix/signature-utils branch from dbd8143 to 85f7bf1 Compare January 22, 2025 15:49

8sunyuan reviewed Jan 22, 2025

View reviewed changes

0xClandestine force-pushed the fix/signature-utils branch from 2ff7718 to 38d2ad8 Compare January 22, 2025 16:13

ypatil12 approved these changes Jan 22, 2025

View reviewed changes

ypatil12 requested changes Jan 27, 2025

View reviewed changes

0xClandestine force-pushed the fix/signature-utils branch from 38d2ad8 to a09d514 Compare January 29, 2025 13:34

chore: forge fmt

9ceb4d8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: signature utils #1015

fix: signature utils #1015

0xClandestine commented Jan 11, 2025 •

edited

Loading

ypatil12 left a comment

0xClandestine commented Jan 11, 2025

ypatil12 left a comment

0xClandestine commented Jan 13, 2025 •

edited

Loading

ypatil12 left a comment

ypatil12 Jan 22, 2025

0xClandestine Jan 22, 2025

8sunyuan Jan 22, 2025

0xClandestine Jan 22, 2025

ypatil12 Jan 22, 2025

0xClandestine Jan 29, 2025

8sunyuan Jan 22, 2025

ypatil12 Jan 22, 2025

ypatil12 left a comment

ypatil12 commented Jan 22, 2025

ypatil12 commented Jan 22, 2025

ypatil12 left a comment

	deployImpl({
	name: type(EigenStrategy).name,
	deployedTo: address(new EigenStrategy({
	_strategyManager: Env.proxy.strategyManager(),
	_pauserRegistry: Env.impl.pauserRegistry()
	}))
	});

fix: signature utils #1015

Are you sure you want to change the base?

fix: signature utils #1015

Conversation

0xClandestine commented Jan 11, 2025 • edited Loading

Changes:

ypatil12 left a comment

Choose a reason for hiding this comment

0xClandestine commented Jan 11, 2025

ypatil12 left a comment

Choose a reason for hiding this comment

0xClandestine commented Jan 13, 2025 • edited Loading

ypatil12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ypatil12 left a comment

Choose a reason for hiding this comment

ypatil12 commented Jan 22, 2025

ypatil12 commented Jan 22, 2025

ypatil12 left a comment

Choose a reason for hiding this comment

0xClandestine commented Jan 11, 2025 •

edited

Loading

0xClandestine commented Jan 13, 2025 •

edited

Loading