-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pectra compatibility #1053
base: feat/prooftra
Are you sure you want to change the base?
Conversation
7a6f8a6
to
fbe5ee2
Compare
8b3076f
to
8679ebb
Compare
8679ebb
to
392022e
Compare
d71e908
to
2e9ab01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK the fork timestamp has never been altered once broadcast, at least not in the last few years, so I think hardcoding it is fine
8beb418
to
d63fded
Compare
d849720
to
f5dbfb8
Compare
@@ -254,6 +255,7 @@ contract EigenPod is Initializable, ReentrancyGuardUpgradeable, EigenPodPausingC | |||
for (uint256 i = 0; i < validatorIndices.length; i++) { | |||
// forgefmt: disable-next-item | |||
totalAmountToBeRestakedWei += _verifyWithdrawalCredentials( | |||
beaconTimestamp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I wonder about the usage of getParentBlockRoot
above.
Can beaconTimestamp
belong to the block after the fork, but the proof itself is over the parent block (aka pre-fork)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR targeting testnet?
We're going to need a different PR for mainnet, since that's landing before slashing, right? (This EigenPod file is compatible with testnet slashing, but not mainnet)
Yup, targeting testnet. There will be a separate mainnet PR. cc @wadealexc |
Updates checkpoint proof system to be Pectra compatible. The breaking change to EigenPods is the
BeaconState
container increasing to have 37 fields, which results in the tree height to be > 5.Overview
BeaconChainProofs
library, since the mainnet proof timestamp will be telegraphed 2-3 weeks in advance of the upgrade. I'm particularly looking for feedback on this approachOpsMultisig
set theproofTimestamp
closer to fork time (this could not be theowner
because on mainnet this is theExecutorMultisig
)EigenPod
pectraForkTimestamp
Deprecation Plan
TODOs