Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added RegisterOperatorWithChurn #514

Draft
wants to merge 4 commits into
base: registration-params-prefix
Choose a base branch
from

Conversation

Sidu28
Copy link
Contributor

@Sidu28 Sidu28 commented Feb 5, 2025

Fixes # .

What Changed?

Added RegisterOperatorWithChurn to avsRegistry chain writer.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@Sidu28 Sidu28 requested a review from MegaRedHand February 5, 2025 20:19
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing

return nil, err
}

w.registryCoordinator.RegisterOperatorWithChurn(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This discards any return values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants