Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Slashing UAM #248

Merged
merged 97 commits into from
Feb 6, 2025
Merged

feat: Slashing UAM #248

merged 97 commits into from
Feb 6, 2025

Conversation

supernovahs
Copy link
Collaborator

@supernovahs supernovahs commented Jan 23, 2025 •
edited
Loading

Fixes #

What Changed?

Slashing UAM

  • Adds RegistrationType in data encoding in register operator
  • Uses 2 different container , one for m2 quorum using rewardsv2 state, second for operator set using testnet slashing
  • modified el writer and reader to know if the case if m2 supported or not.
  • fixed a bug in is_operator_registered_with_operator_set in elreader where if operator set id is 0 , it assumes its m2 state
  • RewardsV2 bindings and Slashing dev bindings support in separate folders

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@supernovahs supernovahs changed the title optimizer = true, update rev for middleware feat:Slashing UAM Jan 23, 2025
supernovahs added 28 commits January 24, 2025 12:44
fix:scripts
dc8e51d
fix dump state, bindings wip , register operator wip
e952a24
chore:update middleware rev
98107cd
fix:script and update bindings
db82d62
fix register to operator sets wip
000d6e9
fix: test_register_for_operator_sets
0e40ff0
fix rpc url
85af638
fix:bls_agg_test import
7f114f5
lint
9c32c7b
lint
f3c1af8
lint
13dac7d
remove usize
6c97f1c
add separate middleware submodule for m2 quorum
505791e
additional script m2 quorums wip
96cff33
m2 and slashing scripts fix wip
7e46922
fix m2 state
5284a39
separate state json files for m2 and operator sets
bc10726
2 seperate contract dirs , delete submodules
9896e9b
forge install: forge-std
ac269cf 
v1.9.5
add forge-std in m2
00df42c
forge install: eigenlayer-middleware
512e776
forge install: forge-std
8752b6b 
v1.9.5
forge install: eigenlayer-middleware
b082270
middleware submodule in operator set contracts
e118cb7
fix:m2 state and scripts
33872a4
wip operator sets script fix
593f9ba
delete submodule for now
eb7a79f
forge install: eigenlayer-middleware
eeb1fb7 
dev
MegaRedHand
MegaRedHand reviewed Feb 6, 2025
View reviewed changes
scripts/generate_rewardsv2_bindings.sh Outdated
@@ -0,0 +1,205 @@
# #!/usr/bin/env sh

# # Exit if any command fails
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this commented code

scripts/bindings.patch Show resolved Hide resolved
@MegaRedHand MegaRedHand changed the title feat:Slashing UAM feat: Slashing UAM Feb 6, 2025
@supernovahs
Copy link
Collaborator Author

@MegaRedHand added a one liner changelog. We'll add detailed later in another PR? since other PRs are more priority?

@MegaRedHand
Copy link
Contributor

Yes! Let's leave the changelog details for another PR

MegaRedHand
MegaRedHand approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile
Comment on lines +59 to +60
.PHONY: copy-env
copy-env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@supernovahs supernovahs merged commit 25979de into dev Feb 6, 2025
11 checks passed
@MegaRedHand MegaRedHand deleted the nova/slashing_uam branch February 6, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
changelog-breaking [changelog] PR changes existing functionality changelog-fixed [changelog] PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supernovahs @MegaRedHand