Splitting to Multiple files and Optimizing #43
Conversation
| @@ -15,15 +15,14 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| timeout-minutes: 30 | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 | |||
There was a problem hiding this comment.
just moving to hash here to make it more safer.
|
It looks there are unused dependency in the PR, I found out by |
| &self, | ||
| polynomial: &PolynomialEvalForm, | ||
| index: u64, | ||
| srs: &SRS, |
There was a problem hiding this comment.
interesting, so you are passing srs as an argument to the function. As opposed to having prover to hold it.
One advantage here is that in the application code, we can just have one srs, and instantiate multiple provers. @samlaf wdyt
There was a problem hiding this comment.
When you say "instantiate multiple provers", you mean "multiple KZG structs"? Problem seems to be that KZG struct holds a fixed sized expanded_roots_of_unity. Should we also pass that in then?
There was a problem hiding this comment.
To me, there is really not much difference, between storing a list of expanded_roots_of_unity, vs storing a list of kzg struct.
|
LGTM, hokulea is able to use the new interfaces, see |
Addresses:
#36
#35