Fix FrameViewer constructor signature

Closes #2197
League-of-Foundry-Developers · Aug 19, 2022 · 8b7b693 · 8b7b693
1 parent 7924e3d
commit 8b7b693
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/foundry/client/apps/sidebar/tabs/settings.d.ts b/src/foundry/client/apps/sidebar/tabs/settings.d.ts
@@ -59,8 +59,11 @@ declare global {
 
   /**
    * A simple window application which shows the built documentation pages within an iframe
+   * @typeParam Options - the type of the options object
    */
-  class FrameViewer extends Application {
+  class FrameViewer<Options extends ApplicationOptions = ApplicationOptions> extends Application<Options> {
+    constructor(url: string, options?: Partial<Options>);
+
     url: string;
 
     /**
@@ -78,7 +81,7 @@ declare global {
      */
     static override get defaultOptions(): typeof Application['defaultOptions'];
 
-    override getData(options?: Partial<ApplicationOptions>): Promise<{ src: string }>;
+    override getData(options?: Partial<Options>): Promise<{ src: string }>;
 
     override close(options?: Application.CloseOptions): ReturnType<Application['close']>;
   }

diff --git a/test-d/foundry/client/apps/sidebar/tabs/settings.test-d.ts b/test-d/foundry/client/apps/sidebar/tabs/settings.test-d.ts
@@ -0,0 +1,7 @@
+import { expectType } from 'tsd';
+
+const frameViewer = new FrameViewer('https://foundryvtt.wiki/', {
+  title: 'My Title'
+});
+
+expectType<string>(frameViewer.url);