-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBF new implementation for Bitcoin #274
Conversation
β @hzheng-ledger Unfortunately this PR does not comply with the Contributing Conventions and will be closed automatically.Feel free to reopen this PR once you have browsed through the guidelines. Found Issues:
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: b38474c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
Codecov Report
@@ Coverage Diff @@
## develop #274 +/- ##
===========================================
+ Coverage 56.94% 58.16% +1.21%
===========================================
Files 471 541 +70
Lines 20945 22364 +1419
Branches 5322 5948 +626
===========================================
+ Hits 11928 13008 +1080
- Misses 8966 9308 +342
+ Partials 51 48 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
replaced by #502 |
π Description
RBF new implementation
β Context
It is a merge of
two PRs before the monorepo:
LedgerHQ/ledger-live-desktop#4862
and
LedgerHQ/ledger-live-common#1826
Jira tickets:
https://ledgerhq.atlassian.net/browse/LIVE-1415
https://ledgerhq.atlassian.net/browse/LIVE-1416
https://ledgerhq.atlassian.net/browse/LIVE-1414
β Checklist
πΈ Demo
Screenshot: (the rbf related options and checkboxes are removed)
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.