Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBF new implementation for Bitcoin #274

Closed
wants to merge 2 commits into from
Closed

Conversation

hzheng-ledger
Copy link
Contributor

@hzheng-ledger hzheng-ledger commented Jun 7, 2022

πŸ“ Description

RBF new implementation

❓ Context

It is a merge of
two PRs before the monorepo:
LedgerHQ/ledger-live-desktop#4862
and
LedgerHQ/ledger-live-common#1826

Jira tickets:
https://ledgerhq.atlassian.net/browse/LIVE-1415
https://ledgerhq.atlassian.net/browse/LIVE-1416
https://ledgerhq.atlassian.net/browse/LIVE-1414

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screenshot: (the rbf related options and checkboxes are removed)

image

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@live-github-bot
Copy link
Contributor

❌ @hzheng-ledger

Unfortunately this PR does not comply with the Contributing Conventions and will be closed automatically.

Feel free to reopen this PR once you have browsed through the guidelines.


Found Issues:

@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Jun 15, 2022 at 10:08AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 15, 2022 at 10:08AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jun 15, 2022 at 10:08AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jun 15, 2022 at 10:08AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

πŸ¦‹ Changeset detected

Latest commit: b38474c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
ledger-live-desktop Major
@ledgerhq/live-common Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@live-github-bot live-github-bot bot closed this Jun 7, 2022
@github-actions github-actions bot added common Has changes in live-common desktop Has changes in LLD translations Translation files have been touched labels Jun 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

@hzheng-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@hzheng-ledger hzheng-ledger reopened this Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #274 (c8f671f) into develop (71091b5) will increase coverage by 1.21%.
The diff coverage is n/a.

❗ Current head c8f671f differs from pull request most recent head b38474c. Consider uploading reports for the commit b38474c to get more accurate results

@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
+ Coverage    56.94%   58.16%   +1.21%     
===========================================
  Files          471      541      +70     
  Lines        20945    22364    +1419     
  Branches      5322     5948     +626     
===========================================
+ Hits         11928    13008    +1080     
- Misses        8966     9308     +342     
+ Partials        51       48       -3     
Flag Coverage Ξ”
bot ?
test 58.16% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...-common/src/families/bitcoin/js-synchronisation.ts 13.06% <0.00%> (-81.79%) ⬇️
...ger-live-common/src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
...edger-live-common/src/families/bitcoin/networks.ts 5.88% <0.00%> (-78.44%) ⬇️
...-common/src/families/hedera/hw-app-hedera/index.ts 16.21% <0.00%> (-78.38%) ⬇️
...edger-live-common/src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
...n/src/families/bitcoin/js-getFeesForTransaction.ts 23.80% <0.00%> (-76.20%) ⬇️
...ve-common/src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-75.39%) ⬇️
...dger-live-common/src/families/hedera/api/mirror.ts 18.75% <0.00%> (-73.44%) ⬇️
...mmon/src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
...edger-live-common/src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
... and 408 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 71091b5...b38474c. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost changed the title rbf new implementation RBF new implementation for Bitcoin Jun 15, 2022
@ghost ghost added the feature ready label Jun 16, 2022
@valpinkman valpinkman assigned LFBarreto and unassigned LFBarreto Jun 28, 2022
@hzheng-ledger
Copy link
Contributor Author

replaced by #502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD feature ready translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants