Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privacy report warning in NBGL Use Case #840

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to propose an implementation of the Security Report as initial warning page or during review (first and last page).
The content of this report can be automatically set using predefined values, or customized by providing all strings, icons and even menu navigation.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • [*] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@nroggeman-ledger nroggeman-ledger force-pushed the add-privacy-report-warning-use-case branch from 29b3c3e to e97173d Compare January 9, 2025 13:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.43%. Comparing base (a2be76c) to head (ae99ee7).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #840       +/-   ##
===========================================
+ Coverage   35.49%   60.43%   +24.94%     
===========================================
  Files          13       13               
  Lines        1606     1820      +214     
===========================================
+ Hits          570     1100      +530     
+ Misses       1036      720      -316     
Flag Coverage Δ
unittests 60.43% <ø> (+24.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger force-pushed the add-privacy-report-warning-use-case branch from 8768988 to ae99ee7 Compare January 15, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants