Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): add moonlight-common-c #3

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Oct 20, 2024

Description

This PR will sit in draft for a while as it depends on nxdk's winapi being extended to support winsock2.h (Windows Socket 2 api). See: XboxDev/nxdk#453

There were at least two attempts at adding this to nxdk, but both were before changes to their network driver: XboxDev/nxdk#611

The nxdk submodule in this PR was changed to a branch based JayFoxRox's attempt, which at least compiles ws2_32... but has other issues when trying to compile enet.

WIP PR/Branch for nxdk adjustments: ReenigneArcher/nxdk#1

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the build/deps/add-moonlight-common-c branch 2 times, most recently from bf349f5 to a8560a5 Compare October 20, 2024 03:19
@ReenigneArcher ReenigneArcher added the help wanted Extra attention is needed label Oct 20, 2024
@ReenigneArcher ReenigneArcher force-pushed the build/deps/add-moonlight-common-c branch 3 times, most recently from 87c321a to 8166935 Compare October 30, 2024 01:41
@ReenigneArcher ReenigneArcher force-pushed the build/deps/add-moonlight-common-c branch from 8166935 to b72ea02 Compare October 30, 2024 01:58
Copy link

@ReenigneArcher
Copy link
Member Author

We can possibly patch enet (https://github.com/cgutman/enet/blob/44c85e16279553d9c052e572bcbfcd745fb74abf/include/enet/enet.h#L15-L19) and moonlight-common-c to load Unix code instead of Windows code (https://github.com/moonlight-stream/moonlight-common-c/blob/d3d3e6cf015cd032ce02718246b52aabd1e12294/src/Platform.h#L16-L46)

OR possibly trick cmake into thinking it's a different OS temprorarily, similar to...
https://github.com/moonlight-stream/moonlight-common-c/blob/d3d3e6cf015cd032ce02718246b52aabd1e12294/CMakeLists.txt#L12-L16

Probably still won't work without additional tweaks to nxdk though as it seems like many of the unix headers are also missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants