Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(l10n): Add language settings for Traditional Chinese #3659

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

ibmibmibm
Copy link

Description

Add language settings for Traditional Chinese. Also need to enable this language in crowdin.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ibmibmibm ibmibmibm changed the title Add language settings for Traditional Chinese chore(l10n): Add language settings for Traditional Chinese Feb 11, 2025
@ReenigneArcher ReenigneArcher marked this pull request as draft February 11, 2025 13:19
@ReenigneArcher
Copy link
Member

Thank you for the interest in adding this language.

Before we agree to add new languages we need a language manager/approver in place. Are you willing to do that? If so, please let me know your Discord username (we use that to keep in touch with the localization helpers), as well as your CrowdIn name (so I can grant you the correct permissions).

Note, that the translations are mostly automated, but the manager is expected to approve and/or change any of the incorrectly translated strings.

@ibmibmibm
Copy link
Author

I have already sent a private message via Discord, which includes the information you need.

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the language in CrowdIn, and made you a language manager/approver. Please let me know if you have any questions on that process.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.61%. Comparing base (9aaa40c) to head (29ef7fd).
Report is 78 commits behind head on l10n_master.

Additional details and impacted files
@@               Coverage Diff               @@
##           l10n_master    #3659      +/-   ##
===============================================
- Coverage        13.01%   11.61%   -1.41%     
===============================================
  Files               66       92      +26     
  Lines            12338    17335    +4997     
  Branches          5653     8099    +2446     
===============================================
+ Hits              1606     2013     +407     
- Misses           10334    14725    +4391     
- Partials           398      597     +199     
Flag Coverage Δ
Linux 11.28% <ø> (?)
Windows 13.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.cpp 0.00% <ø> (ø)

... and 50 files with indirect coverage changes

@ReenigneArcher ReenigneArcher changed the base branch from master to l10n_master February 14, 2025 14:13
@ReenigneArcher ReenigneArcher merged commit 1b14a28 into LizardByte:l10n_master Feb 14, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants