fix(linux): make service start after desktop target #3670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting the Sunshine service at the same time as the desktop causes a race condition, this is currently solved with a delay. I've added an After= dependency for the desktop, which should prevent the service from starting until the desktop has loaded. I've also commented out the delay, since this would not be needed. This is working on my system (Fedora 41 with KDE), but I haven't tested other desktop environments.
|
ReenigneArcher
changed the title
|
Thanks for letting me know, I didn't see that there was a bug on some systems when using the dependencies. The issue looks specific to GNOME, so I'm happy to close the PR. Hopefully phasing out the hardcoded delay can reconsidered when the issue is fixed upstream. |
|
@whacka do you think it might work if we didn't use the following though? These are not part of your PR, but were included when we had that previous bug. Perhaps the bug was related to just having a combination of all of them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting the Sunshine service at the same time as the desktop causes a race condition, this is currently solved with a delay.
My service file was missing the delay (#3653), but I wanted to find a solution without the delay.
I've added an After= dependency for the desktop, which should prevent the service from starting until the desktop has loaded. This avoids the need for the delay, so I've removed it.
This is working on my system (Fedora 41 with KDE), but I'm not sure whether other desktop environments need testing.
Type of Change
.github/...)Checklist