Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unstable timed thread tests #126

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Lowered the lower bound by 1% for tests that are verifying that the thread has woken up within the expected time frame. They ideally should wake up on the lower bound delay, but sometime they wake up a little earlier.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@@ -157,9 +164,9 @@ TEST_F_S(Schedule, Execution, Immediate) {
std::this_thread::sleep_for(1ms);
}

EXPECT_GE(first_call_delay, 0);
EXPECT_GE(first_call_delay, roundTo99(0));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added call here just for consistency even if it's still 0 in the end

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.34%. Comparing base (5e3cdaa) to head (0bafca9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          34       34           
  Lines        2015     2015           
  Branches     1041     1041           
=======================================
  Hits         1901     1901           
+ Misses         51       49    -2     
- Partials       63       65    +2     
Flag Coverage Δ
Linux 91.21% <ø> (ø)
Windows 94.17% <ø> (ø)
macOS 75.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) November 16, 2024 22:19
@ReenigneArcher ReenigneArcher merged commit bbcd179 into LizardByte:master Nov 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants