forked from microsoftgraph/microsoft-graph-devx-api
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interns/feature/ge app mode proxy endpoint #15
Open
omersayshi
wants to merge
39
commits into
interns/dev
Choose a base branch
from
interns/feature/ge-app-mode-proxy-endpoint
base: interns/dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Interns/feature/ge app mode proxy endpoint #15
omersayshi
wants to merge
39
commits into
interns/dev
from
interns/feature/ge-app-mode-proxy-endpoint
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(should be removed before being merged in)
…e-endpoint AB#38714 Set up end point for graph explorer application mode proxy
…s/gracet9182/38715-output-app-token
…s/gracet9182/38716-graph-requests
…app-token AB#38716 MSAL integration with DevXApi application/RSC endpoint
…s/gracet9182/38716-graph-requests
…equests AB#38606 graph requests
…yshi/38712-check-ownership
…wnership AB#38712 Check user resource ownership
acchiang
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
touched base offline; lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just merging in the feature branch into interns/dev. All the commits into the feature branch has been reviewed so this should be a quick one.
Testing Instructions (the same testing instructions as PR#14)
NOTE: Alot of overhead is required to test this PR. to make it easier, ping me on Teams for a ClientId and ClientSecret to avoid registering an app and installing a Teams app on a test tenant with the same ClientId.
/graphproxy/{ADD YOUR GRAPH QUERY HERE}
. Example:/v1.0/teams/{team-id}/channels
Expected behavior