Skip to content

Commit

Permalink
- Fix previous commit due "look" changes re-update viewport engine
Browse files Browse the repository at this point in the history
  • Loading branch information
odil24 authored Jan 1, 2025
1 parent 40b3ac3 commit 9bb55a3
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions engine/viewport.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,28 +59,33 @@ def check_color_management_changes(engine, scene):
engine.last_gamma = view_settings.gamma
if not hasattr(engine, 'last_view_transform'):
engine.last_view_transform = getattr(view_settings, 'view_transform', None)
if not hasattr(engine, 'last_look'):
engine.last_look = getattr(view_settings, 'look', None)

# Check if the exposure, gamma, or view transform have changed
# Check if the exposure, gamma, view transform, or look have changed
exposure_changed = view_settings.exposure != engine.last_exposure
gamma_changed = view_settings.gamma != engine.last_gamma
view_transform_changed = view_settings.view_transform != engine.last_view_transform
look_changed = view_settings.look != engine.last_look

# Update the stored values for the next comparison
engine.last_exposure = view_settings.exposure
engine.last_gamma = view_settings.gamma
engine.last_view_transform = view_settings.view_transform
engine.last_look = view_settings.look

# If any of the values changed, return True
if exposure_changed or gamma_changed or view_transform_changed:
# Handle view transform changes separately
if view_transform_changed:
if exposure_changed or gamma_changed or view_transform_changed or look_changed:
# Handle view transform and look changes separately if needed
if view_transform_changed or look_changed:
if view_settings.view_transform in ['AgX', 'Filmic', 'Khronos PBR Neutral']:
# Return False if only the view transform changed, True otherwise
# Return False if only view transform or look changed and others didn't
return not (exposure_changed or gamma_changed)
return True

return False


def view_update(engine, context, depsgraph, changes=None):
start = time()

Expand Down

0 comments on commit 9bb55a3

Please sign in to comment.