Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download pyluxcore only if needed #960

Merged

Conversation

CodeFHD
Copy link
Member

@CodeFHD CodeFHD commented Jan 11, 2025

I noticed that Blender opens considerably slower with the new wheels than before as an addon.
Upon closer inspection, it is because pyluxcore (+dependencies) are downloaded everytime on startup, not just when needed.

The exact impact on startup time would depend on each individual system and internet connection. In my case, it was around 4.5 seconds, which is very noticable.

The changes implemented by this PR perform:

  1. a check on PyPi for the latest version of the wheel for the local platform
  2. a check if that version is already in the local wheels/ folder
  3. download only if not found

Tested on Windows and Linux, but not Mac.

The architecture strings for mac and linux do not include version info (e.g. just checking 'manylinux', not 'manylinux_2_28'). This is with the assumption that we will not provide multiple separate compatibility builds in the future.

@CodeFHD CodeFHD requested a review from howetuft January 11, 2025 18:28
@howetuft howetuft merged commit 4d48311 into LuxCoreRender:for_blender_4.2_wheels Jan 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants