Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

Fit & Finish #30

Merged
merged 6 commits into from
Jun 21, 2020
Merged

Fit & Finish #30

merged 6 commits into from
Jun 21, 2020

Conversation

mitchmikusek
Copy link

@mitchmikusek mitchmikusek commented Jun 20, 2020 •
edited
Loading

Branch based on feature/vanilla-launcher with PR targeting master.

  • Fixed launch detection issues not causing play button to return
  • Fixed deprecation warning for usage of Buffer Constructor

@mitchmikusek mitchmikusek requested a review from AhiVT June 20, 2020 05:40
@mitchmikusek mitchmikusek changed the title Fit and finish Fit & Finish Jun 20, 2020
@mitch-beewick
Updated Game Launch Detection Regex
9a591dd 
Updated the game launch detection regex to more generally detect game having been lanched across both forge and vanilla servers
This was linked to issues Jun 20, 2020
Crashes or quitting game early sometimes makes launching new instances impossible #4
Closed
Add Vanilla Launch Support #29
Closed
@AhiVT AhiVT marked this pull request as ready for review June 21, 2020 02:35
@AhiVT AhiVT merged commit 6491ea4 into master Jun 21, 2020
@AhiVT AhiVT deleted the fit_and_finish branch June 21, 2020 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AhiVT AhiVT AhiVT approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vanilla Launch Support Crashes or quitting game early sometimes makes launching new instances impossible
4 participants
@mitchmikusek @AhiVT @Dunklheit @mitch-beewick