Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set license plate #114

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Fix set license plate #114

merged 3 commits into from
Jan 14, 2025

Conversation

Deewarz
Copy link
Contributor

@Deewarz Deewarz commented Jan 12, 2025

Fix #112

Also

  • Remove non working random license plate code
  • Use constant for max length

@Deewarz Deewarz requested review from Segfaultd and zpl-zak January 12, 2025 19:36
@Deewarz Deewarz self-assigned this Jan 12, 2025
@Deewarz Deewarz force-pushed the bug/fix-set-license-plate branch from ee74892 to a8300f4 Compare January 12, 2025 19:39
code/shared/modules/vehicle_sync.hpp Outdated Show resolved Hide resolved
@@ -8,6 +8,8 @@

namespace MafiaMP::Shared::Modules {
struct VehicleSync {
static constexpr uint32_t LICENSE_PLATE_MAX_LENGTH = 7;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be in a more global namespace / file. It's not entirely related to the sync.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know where I can put it? I agree but I don't know where.

code/server/src/core/builtins/vehicle.cpp Outdated Show resolved Hide resolved
@Segfaultd Segfaultd merged commit a2e42f7 into master Jan 14, 2025
@Segfaultd Segfaultd deleted the bug/fix-set-license-plate branch January 14, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] [Scripting] Vehicle:setLicensePlate() is not working properly
3 participants