Skip to content

Commit

Permalink
REVERTME: Add some additional logging during ALTER SINK
Browse files Browse the repository at this point in the history
  • Loading branch information
bkirwi committed Feb 5, 2025
1 parent f3fcf18 commit 0b12035
Showing 1 changed file with 21 additions and 1 deletion.
22 changes: 21 additions & 1 deletion src/adapter/src/coord/sequencer/inner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ use smallvec::SmallVec;
use timely::progress::Antichain;
use timely::progress::Timestamp as TimelyTimestamp;
use tokio::sync::{oneshot, watch};
use tracing::{warn, Instrument, Span};
use tracing::{info, warn, Instrument, Span};

use crate::catalog::{self, Catalog, ConnCatalog, DropObjectInfo, UpdatePrivilegeVariant};
use crate::command::{ExecuteResponse, Response};
Expand Down Expand Up @@ -3486,6 +3486,15 @@ impl Coordinator {
}
};

info!(
"preparing alter sink for {}: frontiers={:?} export={:?}",
plan.global_id,
self.controller
.storage_collections
.collections_frontiers(vec![plan.global_id, plan.sink.from]),
self.controller.storage.export(plan.global_id)
);

// Now we must wait for the sink to make enough progress such that there is overlap between
// the new `from` collection's read hold and the sink's write frontier.
self.install_storage_watch_set(
Expand Down Expand Up @@ -3513,6 +3522,17 @@ impl Coordinator {
return;
}
}
{
let plan = &ctx.plan;
info!(
"finishing alter sink for {}: frontiers={:?} export={:?}",
plan.global_id,
self.controller
.storage_collections
.collections_frontiers(vec![plan.global_id, plan.sink.from]),
self.controller.storage.export(plan.global_id)
);
}

let plan::AlterSinkPlan {
item_id,
Expand Down

0 comments on commit 0b12035

Please sign in to comment.