Allow with_snapshot to change when reconciling commands

MaterializeInc · Feb 7, 2025 · 237410d · 237410d
1 parent b759df4
commit 237410d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/storage-types/src/sinks.rs b/src/storage-types/src/sinks.rs
@@ -92,7 +92,9 @@ impl<S: Debug + PartialEq, T: Debug + PartialEq + PartialOrder> AlterCompatible
                 "connection",
             ),
             (envelope == &other.envelope, "envelope"),
-            (with_snapshot == &other.with_snapshot, "with_snapshot"),
+            // This can legally change from true to false once the snapshot has been
+            // written out.
+            (*with_snapshot || !other.with_snapshot, "with_snapshot"),
             (
                 partition_strategy == &other.partition_strategy,
                 "partition_strategy",