Skip to content

Commit

Permalink
Remove unused StorageCollections method
Browse files Browse the repository at this point in the history
It's never called.
  • Loading branch information
bkirwi committed Jan 22, 2025
1 parent efd1ae7 commit a6179d7
Showing 1 changed file with 1 addition and 17 deletions.
18 changes: 1 addition & 17 deletions src/storage-client/src/storage_collections.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,22 +228,6 @@ pub trait StorageCollections: Debug {
/// but hold off on that initially.) Callers must provide a Some if any of
/// the collections is a table. A None may be given if none of the
/// collections are a table (i.e. all materialized views, sources, etc).
async fn create_collections(
&self,
storage_metadata: &StorageMetadata,
register_ts: Option<Self::Timestamp>,
collections: Vec<(GlobalId, CollectionDescription<Self::Timestamp>)>,
) -> Result<(), StorageError<Self::Timestamp>> {
self.create_collections_for_bootstrap(
storage_metadata,
register_ts,
collections,
&BTreeSet::new(),
)
.await
}

/// Like [`Self::create_collections`], except used specifically for bootstrap.
///
/// `migrated_storage_collections` is a set of migrated storage collections to be excluded
/// from the txn-wal sub-system.
Expand Down Expand Up @@ -467,7 +451,7 @@ where
/// reconcile it with the previous state using
/// [StorageCollections::initialize_state],
/// [StorageCollections::prepare_state], and
/// [StorageCollections::create_collections].
/// [StorageCollections::create_collections_for_bootstrap].
pub async fn new(
persist_location: PersistLocation,
persist_clients: Arc<PersistClientCache>,
Expand Down

0 comments on commit a6179d7

Please sign in to comment.