[docs] Explain each LIR operator #31054
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kay-kim
approved these changes
Jan 16, 2025
| @@ -22,11 +35,32 @@ operators: | |||
| uses_memory: False | |||
| memory_details: "" | |||
| expansive: False | |||
| expansive_details: | | |||
| @@ -35,7 +69,8 @@ operators: | |||
| uses_memory: False | |||
| memory_details: "" | |||
| expansive: False | |||
|
|
|||
| expansive_details: | | |||
| Each row has _less_ data (i.e., shorter rows, but same number of rows). | |||
| @@ -241,6 +241,10 @@ Below the plan, a "Used indexes" section indicates which indexes will be used by | |||
| ### Reference: Plan operators | |||
|
|
|||
| {{< tabs >}} | |||
| {{< tab "In fully optimized LIR plans" >}} | |||
| {{< explain-plans/operator-table data="explain_plan_operators" planType="lir" >}} | |||
There was a problem hiding this comment.
Are we talking about EXPLAIN PHYSICAL PLAN for VIEW/MATERIALIZED VIEW here, yes? If so, I think we should go with the PHYSICAL plans.
| example: "`Union 7 10 11 14 (consolidates output)`" | ||
|
|
||
| - operator: ArrangeBy | ||
| plan_types: "optimized" |
| @@ -218,6 +386,16 @@ operators: | |||
| expansive: False | |||
| example: "`ArrangeBy keys=[[#0]]`" | |||
|
|
|||
| - operator: Arrange | |||
There was a problem hiding this comment.
Was this supposed to be ArrangeBy? (See comment on line https://github.com/MaterializeInc/materialize/pull/31054/files#diff-8a8cb8a7b9f7777ed5d1f88369aa9a4c9ef159e56cd49f4f1a2e309435d707deR370). -- although, the example has Arrange 12 ... but the description talks about keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is new syntax for showing LIR terms in
mz_introspection.mz_lir_mappingafter #29848 and #30899; this adds documentation for it.Preview link
Motivation
Tips for reviewer
I snuck in a tiny fix to how
GetandProjectwere described---theexpansive_detailsforGetdescribedProject.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.