Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[copy_from] AWS source #31144

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ParkMyCar
Copy link
Member

@ParkMyCar ParkMyCar commented Jan 22, 2025

Stacked on top of: #30956

This PR implements a new AwsS3 OneshotSource that allows copying in files from S3, e.g.

COPY INTO my_table FROM 's3://my-test-bucket' (FORMAT CSV, FILES = ['important.csv']);

Along with FILES = [<files>] we also support a PATTERN = <glob> option which allows copying multiple files all at once.

Motivation

Fixes https://github.com/MaterializeInc/database-issues/issues/8860
Fixes https://github.com/MaterializeInc/database-issues/issues/8855

Tips for reviewer

Review only the final commit, the one titled "start, implementation of an S3 oneshot source"

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar force-pushed the copy/aws-source branch 6 times, most recently from 4babd12 to 7defd19 Compare January 23, 2025 20:00
* plumb the CSV params through to oneshot_source::CsvFormat to handle different delimiters and what not
* add support for compressed CSVs using async_compression
    * various Bazel changes for the C dependencies from the compression algorithms
* add a new OneshotSource implementation
* support the FILES and PATTERN options for COPY FROM
@ParkMyCar ParkMyCar marked this pull request as ready for review January 24, 2025 00:20
@ParkMyCar ParkMyCar requested review from a team as code owners January 24, 2025 00:20
@ParkMyCar ParkMyCar requested a review from aljoscha January 24, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant