Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest Timely #31158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update to latest Timely #31158

wants to merge 1 commit into from

Conversation

antiguru
Copy link
Member

Point Materialize at latest Timely. We need to incorporate some changes
around reachability logging, which is now typed, and event iterators that
return cow'ed data.

Some of the complexity stems from the fact that event links are
single-writer, so we need separate event links for each reachability log
variant.

Signed-off-by: Moritz Hoffmann [email protected]

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@antiguru antiguru requested a review from teskje January 23, 2025 15:19
@antiguru antiguru marked this pull request as ready for review January 23, 2025 15:19
@antiguru antiguru requested review from aljoscha, jkosh44 and a team as code owners January 23, 2025 15:19
jkosh44
jkosh44 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapter changes LGTM

@antiguru
Update to latest Timely
b01e6c5 
Point Materialize at latest Timely. We need to incorporate some changes
around reachability logging, which is now typed, and event iterators that
return cow'ed data.

Some of the complexity stems from the fact that event links are
single-writer, so we need separate event links for each reachability log
variant.

Signed-off-by: Moritz Hoffmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkosh44 jkosh44 jkosh44 approved these changes

@teskje teskje Awaiting requested review from teskje

@aljoscha aljoscha Awaiting requested review from aljoscha aljoscha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antiguru @jkosh44