libmatroska2: 0 duration frames can be keyframes #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The part of the Matroska specifications that claimed that Blocks from a BlockGroup with duration zero are no keyframes has been dropped in 9313a00f7391a285f95e9d6f0a5f8f3f80ed4779. This commit brings libmatroska2 in line with this change. The earlier version e.g. made mkvalidator warn about files muxed by FFmpeg that contained pgs subtitles (which are muxed as zero-duration subtitles, which is spec-compliant). Signed-off-by: Andreas Rheinhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part of the Matroska specifications that claimed that Blocks from a BlockGroup with duration zero are no keyframes has been dropped in 9313a00f7391a285f95e9d6f0a5f8f3f80ed4779. This commit brings libmatroska2 in line with this change.
The earlier version e.g. made mkvalidator warn about files muxed by FFmpeg that contained pgs subtitles (which are muxed as zero-duration subtitles, which is spec-compliant).
rebased version of #40