clang-tidy: fix missing special member func

Found with: cppcoreguidelines-special-member-functions Replaced several functions with using declarations and added missing stuff elsewhere. Signed-off-by: Rosen Penev <[email protected]>
Matroska-Org · Feb 2, 2024 · c9b80c7 · c9b80c7
1 parent 3e98251
commit c9b80c7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/matroska/KaxBlock.h b/matroska/KaxBlock.h
@@ -98,6 +98,7 @@ class MATROSKA_DLL_API SimpleDataBuffer : public DataBuffer {
     }
 
     SimpleDataBuffer(const SimpleDataBuffer & ToClone);
+    SimpleDataBuffer& operator=(const SimpleDataBuffer &) = delete;
 };
 
 /*!
@@ -179,10 +180,9 @@ DECLARE_MKX_MASTER(KaxBlockGroup)
 
 class MATROSKA_DLL_API KaxInternalBlock : public libebml::EbmlBinary {
   public:
-    KaxInternalBlock(const libebml::EbmlCallbacks & classInfo)
-      :libebml::EbmlBinary(classInfo)
-    {}
+    using EbmlBinary::EbmlBinary;
     KaxInternalBlock(const KaxInternalBlock & ElementToClone);
+    KaxInternalBlock& operator=(const KaxInternalBlock &) = delete;
     ~KaxInternalBlock() override;
     bool SizeIsValid(std::uint64_t size) const override
     {
@@ -311,6 +311,9 @@ class MATROSKA_DLL_API KaxBlockBlob {
       delete Block.group;
   }
 
+  KaxBlockBlob(const KaxBlockBlob&) = delete;
+  KaxBlockBlob& operator=(const KaxBlockBlob&) = delete;
+
   operator KaxBlockGroup &() const;
   operator KaxSimpleBlock &() const;
   operator KaxInternalBlock &() const;
@@ -337,8 +340,6 @@ class MATROSKA_DLL_API KaxBlockBlob {
 
 DECLARE_MKX_BINARY_CONS(KaxBlockVirtual)
   public:
-    ~KaxBlockVirtual() override;
-
     /*!
       \note override this function to generate the Data/Size on the fly, unlike the usual binary elements
     */

diff --git a/matroska/KaxBlockData.h b/matroska/KaxBlockData.h
@@ -22,7 +22,6 @@ namespace libmatroska {
 */
 DECLARE_MKX_SINTEGER_CONS(KaxReferenceBlock)
   public:
-        ~KaxReferenceBlock() override;
     /*!
       \brief override this method to compute the timestamp value
     */

diff --git a/matroska/KaxCues.h b/matroska/KaxCues.h
@@ -22,6 +22,9 @@ DECLARE_MKX_MASTER(KaxCues)
   public:
     ~KaxCues() override;
 
+    KaxCues(const KaxCues&) = default;
+    KaxCues& operator=(const KaxCues&) = delete;
+
     //bool AddBlockGroup(const KaxBlockGroup & BlockReference); // deprecated
     bool AddBlockBlob(const KaxBlockBlob & BlockReference);
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,7 +22,6 @@ namespace libmatroska { @@
     */
     DECLARE_MKX_SINTEGER_CONS(KaxReferenceBlock)
       public:
-            ~KaxReferenceBlock() override;
         /*!
           \brief override this method to compute the timestamp value
         */
@@ Expand Down @@