Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellExt: Handle .url files #1011

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Jan 14, 2025

Only works on new Windows 11 context menu. Windows File Explorer's classic context menu does not show any shell extensions for .url files.

URL files for testing.zip

@cjee21
Copy link
Collaborator Author

cjee21 commented Jan 14, 2025

Note: #1002 needs to be rebased after this again.

Copy link
Member

@JeromeMartinez JeromeMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
One small addition please:

Source/WindowsShellExtension/dllmain.cpp Show resolved Hide resolved
@cjee21 cjee21 force-pushed the shellext-url branch 2 times, most recently from 91e9a32 to cd6e0c9 Compare January 14, 2025 11:51
@cjee21
Copy link
Collaborator Author

cjee21 commented Jan 14, 2025

Does not work on Qt GUI as expected. Need some changes in Qt code to handle URL as command line parameter.

It is because of:

fileNames[i] = QDir::toNativeSeparators(fileNames[i]);

Commenting this line out makes it work for urls.

@JeromeMartinez
Copy link
Member

Snapshot.

@JeromeMartinez JeromeMartinez merged commit 95a5818 into MediaArea:master Jan 14, 2025
3 checks passed
@JeromeMartinez
Copy link
Member

@cjee21 it works great, thanks!

@cjee21 cjee21 deleted the shellext-url branch January 15, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants